Update deploy_revision tests to actually check revision #14342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the code is not checking the revision, it just prints out "true" or "false". Update the test to check this response. Note: this is against the 2.9 branch, and won't fix the failure on 3.0. That's something different (related to async downloads and resources that Heather is looking at).
barrettj12
reviewed
Jul 20, 2022
barrettj12
approved these changes
Jul 20, 2022
Merged
jujubot
added a commit
that referenced
this pull request
Jul 20, 2022
#14350 Merge 2.9 #14329 [JUJU-1466] Filter by model uuid when querying azure instances #14318 [JUJU-1196] refactor nw-constraints-aws test #14333 [JUJU-1468] Fixed test agents lxd #14339 Fix cli/local_charms test due to deleted GitHub repo #14342 Update deploy_revision tests to actually check revision #14337 [JUJU-1475] Added lxd constraints tests #14335 More unit charm url work #14343 [JUJU-1480] Add support for retry-provisioning --all #14345 [JUJU-1480] Fix display of upgrading-from for subordinate units ``` # Conflicts: # api/client/client/client.go # cmd/juju/model/retryprovisioning.go # migration/precheck.go # migration/precheck_test.go # rpc/params/internal.go # tests/suites/agents/key_workers_run.sh ``` ## QA steps See PRs [JUJU-1466]: https://warthogs.atlassian.net/browse/JUJU-1466?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1196]: https://warthogs.atlassian.net/browse/JUJU-1196?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1468]: https://warthogs.atlassian.net/browse/JUJU-1468?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1475]: https://warthogs.atlassian.net/browse/JUJU-1475?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1480]: https://warthogs.atlassian.net/browse/JUJU-1480?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1480]: https://warthogs.atlassian.net/browse/JUJU-1480?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code is not checking the revision, it just prints out
"true" or "false". It doesn't make the test fail, but this updates the
test to actually check this response.
Note: this is against the 2.9 branch, and won't fix the failure on 3.0.
That's something different (related to async downloads and resources
that Heather is looking at).