[JUJU-1494] Fast refresh charm #14368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid timing window where the ID hasn't been set as the charm hasn't been downloaded yet. A very small window.
Adjust error message on revision without channel to match juju 3.0
manadart
reviewed
Jul 22, 2022
|
Tested locally: https://pastebin.canonical.com/p/DpkkpJC2Xg/ Test passed successfully. |
wallyworld
approved these changes
Jul 22, 2022
I thought about it, but seemed over engineering at this point. As the code comment says, we can add retry. |
|
Unfortunately we cannot check on the server side too, as AddCharm is used by both deploy and refresh. |
|
/merge |
1 similar comment
|
/merge |
5 tasks
jujubot
added a commit
that referenced
this pull request
Oct 19, 2022
…regression #14788 A few things were lost in merges from 2.9 into develop or 3.0, bring them back. * loop to ensure that deploy by revision refresh is working with async charm download, from #14368 * latest vs default track, from #14470 ## QA steps *Commands to run to verify that the change works.* From #14470: ```sh $ juju deploy mysql-router Located charm "mysql-router" in charm-hub, revision 34 Deploying "mysql-router" from charm-hub charm "mysql-router", revision 34 in channel 8.0/stable on focal $ juju deploy mysql-router --channel latest mysql-router-latest Located charm "mysql-router" in charm-hub, revision 15 Deploying "mysql-router-latest" from charm-hub charm "mysql-router", revision 15 in channel latest/stable on focal # the channel here should be latest/stable, however there is a bug in charmhub server right now. $ juju deploy ubuntu Located charm "ubuntu" in charm-hub, revision 20 Deploying "ubuntu" from charm-hub charm "ubuntu", revision 20 in channel stable on focal ``` Other QA ```sh (cd tests ; ./main.sh -v deploy test_deploy_revision) (cd tests ; ./main.sh -v deploy test_deploy_bundles) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check charm origin ID before attempting to refresh charmhub charms. Prevents a case where refresh called before charm is downloaded.
Account for change to refresh in updated run_deploy_revision_upgrade.
Drive by fix of run_deploy_revision_fail.
QA steps
(cd tests ; ./main.sh -v deploy test_deploy_revision )