Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUJU-1506] Changed command summary from 3SG to 2SG. #14374

Merged

Conversation

tmihoc
Copy link
Member

@tmihoc tmihoc commented Jul 26, 2022

Please provide the following details to expedite review (and delete this heading)

I've noticed inconsistencies in the command summary lines---some use second person singular and others third person singular. It becomes grating when you look at a global summary (e.g., juju help commands, also cascading into https://juju.is/docs/olm/commands). I think it's best to use second person throughout.

Checklist

  • Comments answer the question of why design decisions were made

QA steps

juju help add-cloud

Documentation changes

Update https://juju.is/docs/olm/juju-add-cloud .

@tmihoc tmihoc requested a review from anvial July 27, 2022 14:53
Copy link
Member

@anvial anvial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m

@tmihoc
Copy link
Member Author

tmihoc commented Jul 28, 2022

/merge

@jujubot jujubot merged commit 37a0350 into juju:develop Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants