[JUJU-1453] Test charm cleanup #14375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
approved these changes
Jul 29, 2022
| @@ -1,15 +1,15 @@ | |||
| series: bionic | |||
| applications: | |||
| lxd-profile: | |||
| charm: cs:~juju-qa/bionic/lxd-profile-without-devices-2 | |||
| charm: juju-qa-lxd-profile-without-devices | |||
There was a problem hiding this comment.
we need to ensure we retain in a test bundle somewhere (if not already thought about):
- revision pinning
- deploy from cs
There was a problem hiding this comment.
i'll add it into the todo. I'll construct a test specifically for this purpose.
tlm
force-pushed
the
charm-cleaning
branch
3 times, most recently
from
605ca50
to
fa65bb1
Compare
|
/merge |
1 similar comment
|
/merge |
Cleaning up local copies of the Ubuntu charm in favour of Charmhub.
Also made deployments of test charm from charmhub instead of locally.
- Updated for packing and uploading with charmcraft.
- Moved usages of lxd-profile-without-devices over to charmhub.
- Consolidates the lxd profile subordinate charm. - Updates charm for use with charmhub and charmcraft.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued work that is stable for cleaning up charms in our testing infra.
Checklist
QA steps
Documentation changes
N/A
Bug reference
N/A