Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JUJU-1512] Update juju/cmd to v3.0.1 #14385

Merged
merged 3 commits into from
Aug 3, 2022
Merged

[JUJU-1512] Update juju/cmd to v3.0.1 #14385

merged 3 commits into from
Aug 3, 2022

Conversation

barrettj12
Copy link
Contributor

@barrettj12 barrettj12 commented Jul 28, 2022 •
edited
Loading

This pulls through a small change (juju/cmd#81) so now we don't add an extra newline to output with non-default formatters.

Changes

The following commands have had an extraneous newline removed after tabular output. I have changed the tests to match.

  • exec
  • operations
  • run
  • show-task
  • disabled-commands
  • clouds
  • credentials
  • regions
  • enable-ha
  • controllers (+ feature tests)
  • models (+ feature tests)
  • find-offers
  • offers
  • show-offer
  • list-firewall-rules
  • machines
  • show-machine
  • model-config
  • charm-resources
  • resources (+ feature tests)
  • secrets
  • show-status-log
  • status (+ feature tests)
    • The status --format oneline output actually had an extra newline before, which I have removed.
  • storage (+ feature tests)
  • storage-pools (+ feature tests)
  • users (+ feature tests)
  • model-defaults (feature tests only)
  • jujuc secret-get for yaml output

The following commands didn't have an extraneous newline, so I've updated their formatting code to explicitly add a newline:

  • metrics
  • commits
  • payloads
  • agreements
  • plans
  • wallets
  • show-wallet
  • sla
  • space
  • move-to-space
  • whoami
  • get-constraints
  • get-model-constraints
  • jujuc secret-get for single output

TODO

  • fix the status command/tests
  • check the CI passes
  • test a few commands manually

@barrettj12 barrettj12 added dependencies Pull requests that update a dependency file do not merge Even if a PR has been approved, do not merge the PR! 3.0 labels Jul 28, 2022
@barrettj12 barrettj12 force-pushed the exec-lf branch 2 times, most recently from 5c47d57 to 52e0722 Compare August 2, 2022 01:40
@barrettj12
Copy link
Contributor Author

/build

hpidcock
hpidcock approved these changes Aug 2, 2022
View reviewed changes
cmd/juju/firewall/listrules_test.go Outdated Show resolved Hide resolved
cmd/juju/metricsdebug/metrics.go Outdated Show resolved Hide resolved
cmd/juju/model/listcommits.go Outdated Show resolved Hide resolved
cmd/juju/romulus/listagreements/listagreements.go Outdated Show resolved Hide resolved
cmd/juju/romulus/listplans/list_plans.go Outdated Show resolved Hide resolved
cmd/juju/romulus/listwallets/list-wallets.go Outdated Show resolved Hide resolved
cmd/juju/romulus/showwallet/show_wallet.go Outdated Show resolved Hide resolved
cmd/juju/romulus/sla/sla.go Outdated Show resolved Hide resolved
cmd/juju/status/status_internal_test.go Outdated Show resolved Hide resolved
worker/uniter/runner/jujuc/secret-get.go Outdated Show resolved Hide resolved
@barrettj12 barrettj12 changed the title Update juju/cmd to v3.0.1 [JUJU-1512] Update juju/cmd to v3.0.1 Aug 2, 2022
@barrettj12
Copy link
Contributor Author

/merge

@jujubot jujubot merged commit ae08b34 into juju:develop Aug 3, 2022
@barrettj12 barrettj12 deleted the exec-lf branch August 3, 2022 04:33
@manadart manadart mentioned this pull request Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpidcock hpidcock hpidcock approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file do not merge Even if a PR has been approved, do not merge the PR!
Projects
None yet
Milestone
No milestone
3 participants
@barrettj12 @hpidcock @jujubot