Install shfmt during static analysis to enable lint #14391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-w-shaw
force-pushed
the
enable_shfmt_gh_action
branch
from
5f72a84
to
b0a174e
Compare
|
/merge |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If shfmt isn't installed, the static analysis test suite skips this test. This has been allowing lint failures to pass unnoticed
Checklist
[ ] Code style: imports ordered, good names, simple structure, etc[ ] Comments saying why design decisions were made[ ] Go unit tests, with comments saying what you're testing[ ] doc.go added or updated in changed packagesQA steps
Successfully run the static analysis gh action, verifying shfmt linting runs