Fake authorizer takes a tag #144
Conversation
…rizer-takes-a-tag Conflicts: state/apiserver/agent/agent_test.go state/apiserver/root.go
|
PTAL. I've merged trunk and this is ready for review. |
| @@ -42,7 +42,7 @@ func NewDeployerAPI( | |||
| } | |||
| getAuthFunc := func() (common.AuthFunc, error) { | |||
| // Get all units of the machine and cache them. | |||
| thisMachineTag := authorizer.GetAuthTag() | |||
| thisMachineTag := authorizer.GetAuthTag().String() | |||
There was a problem hiding this comment.
Why is this changed to a String() here?
There was a problem hiding this comment.
because getAllUnits takes a string, not a names.Tag ... ah, but getAllUnits is only called from here, and takes the string and turns it into a tag ... fixed.
|
LGTM with any required changes as per comments. Also, please add a //comment for the deleted test cases where the tag is no longer valid if we intend to come back and rework things or else just delete the line |
got it, |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Update all dependencies
No description provided.