Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc.go to cmd/juju/config #14406

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Conversation

barrettj12
Copy link
Contributor

Checklist

If an item is not applicable, use ~strikethrough~.

  • Code style: imports ordered, good names, simple structure, etc
  • Comments saying why design decisions were made
  • Go unit tests, with comments saying what you're testing
  • Integration tests, with comments saying what you're testing
  • doc.go added or updated in changed packages

Copy link
Member

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Looks fine, but two nit comments to fix if you want.

cmd/juju/config/doc.go Outdated Show resolved Hide resolved
cmd/juju/config/doc.go Outdated Show resolved Hide resolved
@barrettj12
Copy link
Contributor Author

/merge

@jujubot jujubot merged commit b76a251 into juju:develop Aug 2, 2022
@barrettj12 barrettj12 deleted the config-doc-go branch August 2, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants