Update secret hook commands for new syntax #14432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
force-pushed
the
secret-create-update
branch
6 times, most recently
from
ea550c3
to
f4914db
Compare
hpidcock
approved these changes
Aug 8, 2022
| return "", errors.NotValidf("rotate interval %q", arg.RotateInterval) | ||
| func toValue[T any](v *T) T { | ||
| if v == nil { | ||
| return *new(T) |
There was a problem hiding this comment.
can't this just be
var x T
return x
There was a problem hiding this comment.
Sure, tomato, tomarto?
wallyworld
force-pushed
the
secret-create-update
branch
from
f4914db
to
59c7e95
Compare
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first of several which will update the secret hook commands to conform to the approved syntax.
The front end is wired up but the apiserver side is still todo.
The create and update commands are done. Still todo is get and remove.
Checklist
If an item is not applicable, use
~strikethrough~.[ ] Integration tests, with comments saying what you're testing[ ] doc.go added or updated in changed packagesQA steps
None yet - more PRs needed.