Add secrets watcher backend for notifying of secret revision changes #14450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
force-pushed
the
secrets-watcher-backend
branch
from
667d7ae
to
d4a54b3
Compare
wallyworld
force-pushed
the
secrets-watcher-backend
branch
from
d4a54b3
to
8766d8b
Compare
wallyworld
force-pushed
the
secrets-watcher-backend
branch
from
8766d8b
to
94d0bbc
Compare
|
/merge |
1 similar comment
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add backend support for watching changes to secrets.
The watcher looks at the secrets consumers collection - we need to add the latest secret revision to the doc and this is updated when a secret is updated. Extra logic was also needed to handle concurrent updates.
The Get/Save secrets consumer methods were moved off the secrets service interface and onto a new interface which is backed by State. The secrets service interface is purely for managing secrets themselves.
Also a couple of driveby fixes to naming.
Checklist
[ ] doc.go added or updated in changed packagesQA steps
Just unit tests for now, until next PR.