[JUJU-1684] Commit secret updates, deletes, access changes at end of hook execution #14500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
force-pushed
the
batch-secret-updates
branch
4 times, most recently
from
e01db67
to
22dc1c1
Compare
hpidcock
approved these changes
Aug 24, 2022
| @@ -2718,6 +2720,43 @@ func (u *UniterAPI) commitHookChangesForOneUnit(unitTag names.UnitTag, changes p | |||
| modelOps = append(modelOps, modelOp) | |||
| } | |||
|
|
|||
| if len(changes.SecretDeletes) > 0 { | |||
| result, err := u.SecretsManagerAPI.RemoveSecrets(params.SecretURIArgs{Args: changes.SecretDeletes}) | |||
There was a problem hiding this comment.
obviously would be great to get these into the txn
There was a problem hiding this comment.
yeah. we're getting into 2 phase commit territory if the backend is not juju etc.
i'd like to come back to this when the design has evolved a bit, will leave a todo
wallyworld
force-pushed
the
batch-secret-updates
branch
from
22dc1c1
to
cd2eb4c
Compare
|
/merge |
wallyworld
force-pushed
the
batch-secret-updates
branch
from
cd2eb4c
to
a1b81db
Compare
|
/merge |
wallyworld
force-pushed
the
batch-secret-updates
branch
from
a1b81db
to
c0f98ad
Compare
|
/merge |
wallyworld
force-pushed
the
batch-secret-updates
branch
from
c0f98ad
to
84a7858
Compare
|
/merge |
wallyworld
changed the title
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secret updates, deletes, access changes are cached on the hook context and committed when the hook has finished running.
Creates still need to happen immediately since the returned URI is needed for subsequent operations.
Also fix some unit agent context API calls to use a secret uri not a string.
Checklist
[ ] Integration tests, with comments saying what you're testing[ ] doc.go added or updated in changed packagesQA steps