Better handling of /etc/profile.d/juju-proxy.sh script creation

[ghost]

Better handling of /etc/profile.d/juju-proxy.sh script creation, so that both the controller direct script and non-controller cloud-init script behave as desired.

Checklist

• Code style: imports ordered, good names, simple structure, etc
  - [] Comments saying why design decisions were made
• Go unit tests, with comments saying what you're testing
  - [] Integration tests, with comments saying what you're testing
  - [] doc.go added or updated in changed packages

QA steps

Confirm there is no "command not found" output when doing juju ssh to a bootstrapped controller or a deployed unit and that the content of /etc/profile.d/juju-proxy.sh is as desired.

$ juju bootstrap lxd


$ juju ssh -m controller 0
[no "command not found" error]


$ juju ssh -m controller 0 'cat /etc/profile.d/juju-proxy.sh'

# Added by juju
[ -f "/etc/juju-proxy.conf" ] && . "/etc/juju-proxy.conf"


$ juju deploy -m default ubuntu


$ juju ssh -m default 0
[no "command not found" error]


$ juju ssh -m default 0 'cat /etc/profile.d/juju-proxy.sh'

# Added by juju
[ -f "/etc/juju-proxy.conf" ] && . "/etc/juju-proxy.conf"

Bug reference

https://bugs.launchpad.net/juju/+bug/1994911

[jujubot]

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial @juanmanuel-tirado

[jujubot]

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial @juanmanuel-tirado

[jujubot]

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial @juanmanuel-tirado

[wallyworld]

/merge