[JUJU-2586] Fix LP19988587 Can't switch from edge channel to stable channel #15141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not. Fix for LP1988587. With charm store you could update the channel to be used in the future, even if the charm itself didn't require upgrade. Allow the same behavior for charm hub charms.
cderici
approved these changes
Feb 2, 2023
Unit tests and SetCharm called by the Update application facade method will not contain a charm origin. Ensure we don't panic on this in the real world. The Update facade method is only kept for compatibility with older juju 2.x clients. With juju 3.0, we can revaluate checking for an empty charm origin in the facade and updating the unit tests.
hmlanigan
force-pushed
the
198858701-refresh-switch-no-rev-change
branch
from
5d1b92f
to
9c50fac
Compare
hmlanigan
added
do not merge
hmlanigan
commented
Feb 3, 2023
A miss in commit to fix LP1988587.
Test cover scenarios in LP1988587, where refresh failed due to a lack of new available charm revision, however the switch or channel flags were used.
Add small tweeks to tests including fixing model names, correcting a charm name and enhancing comments.
hmlanigan
force-pushed
the
198858701-refresh-switch-no-rev-change
branch
from
2459a2f
to
823cf42
Compare
cderici
approved these changes
Feb 7, 2023
|
/merge |
Merged
jujubot
added a commit
that referenced
this pull request
Feb 8, 2023
#15164 Merge from 2.9 to bring forward: - #15129 from jack-w-shaw/JUJU-2615_debug_log_for_caas - #15141 from hmlanigan/198858701-refresh-switch-no-rev-change - #15154 from manadart/2.9-migration-rollback - #15157 from manadart/2.9-sync-agent-binary - #15117 from cprivitere/whitelist-10-networks Trivial conflicts.
hmlanigan
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow an application's channel to be updated when refreshing even if the charm revision is the same so no other change is needed. This fixes a regression in behavior between charm hub and charm store charms. Because it's a regression, only a small change was required.
QA steps
Today, all risk levels of the latest track for the ubuntu charm are the same. Makes a good test candidate.
Bug reference
https://bugs.launchpad.net/juju/+bug/1988587