Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-microk8s cloud finding. #15336

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Fix non-microk8s cloud finding. #15336

merged 1 commit into from
Apr 13, 2023

Conversation

hpidcock
Copy link
Member

@hpidcock hpidcock commented Mar 27, 2023 •
edited
Loading

When microk8s is not installed and you want to bootstrap a non-microk8s cloud, it would error:

$ juju bootstrap minikube --debug
...
13:37:21 INFO  cmd bootstrap.go:1279 cloud "minikube" not found, trying as a provider name
ERROR unknown cloud "minikube", please try "juju update-public-clouds"

QA steps

Uninstall microk8s and install minikube(or another k8s in kubeconfig). Make sure you can at least attempt a bootstrap.

Documentation changes

N/A

Bug reference

N/A

@hpidcock hpidcock added the 3.2 label Mar 27, 2023
@hpidcock
Copy link
Member Author

/merge

@hpidcock hpidcock added failed to land The bot failed to merge the PR 3.3 and removed 3.2 labels Mar 28, 2023
@hpidcock hpidcock changed the base branch from develop to 3.2 April 13, 2023 06:58
@hpidcock hpidcock added 3.2 and removed 3.3 labels Apr 13, 2023
@hpidcock
Copy link
Member Author

/merge

@hpidcock hpidcock removed the failed to land The bot failed to merge the PR label Apr 13, 2023
@hpidcock
Copy link
Member Author

/merge

@jujubot jujubot merged commit 6184308 into juju:3.2 Apr 13, 2023
@hpidcock hpidcock mentioned this pull request May 30, 2023
Merged
jujubot added a commit that referenced this pull request Jun 2, 2023
@jujubot
Merge pull request #15674 from hpidcock/merge-2.9-3.1-sidecar-teardown
5869687 
#15674

Forward ports:
- #15636
- #15650
- #15652
- #15653
- #15633
- #15657
- #15660
- #15661
- #15662
- #15663

Back ports:
- #15336

New changes:
- juju/description/v4 to v4.0.9

Minor conflicts across most files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyworld wallyworld wallyworld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hpidcock @wallyworld @jujubot