Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JUJU-3343] dont prompt force when forcing #15399

Merged
merged 1 commit into from Mar 30, 2023
Merged

[JUJU-3343] dont prompt force when forcing #15399

merged 1 commit into from Mar 30, 2023

Conversation

jack-w-shaw
Copy link
Member

Also flyby fix a spelling mistake

QA steps

$ juju bootstrap aws/eu-west-2 aws
$ juju add-model m
$ juju add-machine
$ juju add-machine lxd:0
$ juju model-config mode="requires-prompt"
$ juju remove-machine 0
WARNING This command will perform the following actions:
will remove machine 0
will remove machine 0/lxd/0

This will require `--force`

Continue [y/N]? n

$ juju remove-machine 0 --force
WARNING This command will perform the following actions:
will remove machine 0
will remove machine 0/lxd/0

Continue [y/N]? y

Bug reference

https://bugs.launchpad.net/juju/+bug/2011629

hmlanigan
hmlanigan approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@hmlanigan hmlanigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that's for fixing it!

@jack-w-shaw
Copy link
Member Author

/merge

@jujubot jujubot merged commit dbaae24 into juju:3.0 Mar 30, 2023
18 checks passed
@jack-w-shaw jack-w-shaw deleted the JUJU-3343_dont_prompt_force_when_forcing branch March 30, 2023 14:11
@juanmanuel-tirado juanmanuel-tirado mentioned this pull request Apr 4, 2023
Merged
jujubot added a commit that referenced this pull request Apr 4, 2023
@jujubot
Merge pull request #15422 from juanmanuel-tirado/merge-3.0-3.1_20230404
f43d417 
#15422

Merge 3.0 to 3.1 after #15418 and #15419 changes.

## To be ported

0e69838 (upstream/3.0) Merge pull request #15420 from juanmanuel-tirado/merge-2.9-3.0_20230404
dbaae24 Merge pull request #15399 from jack-w-shaw/JUJU-3343_dont_prompt_force_when_forcing
@barrettj12 barrettj12 mentioned this pull request Apr 4, 2023
Merged
@jack-w-shaw jack-w-shaw mentioned this pull request Apr 17, 2023
Merged
jujubot added a commit that referenced this pull request Apr 17, 2023
@jujubot
Merge pull request #15494 from jack-w-shaw/3.2-into-develop
44387bc 
#15494

Merges:
- #15399
- #15395
- #15414
- #15417
- #15418
- #15419
- #15413
- #15420
- #15422
- #15424
- #15416
- #15428
- #15423
- #15426

Conflicts resolved trivially
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmlanigan hmlanigan hmlanigan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jack-w-shaw @hmlanigan @jujubot