-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 2.9 to 3.1 with sidecar teardown #15674
Merged
Merged
Changes from 58 commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
d94e2e8
Introduces the ability to teardown sidecar charms.
tlm 3a87c38
Prevent introduction of dead units or unwanted units (by scale).
hpidcock 2791f38
Handle unit not found as dead life for removed unit.
hpidcock 359b142
Safeguard against unit introduction introducing new unit in scale down.
hpidcock 3e60fee
Fix lifeflag worker to check for ErrNotFound not errors.NotFound.
hpidcock 4b9f022
Improve caasapplicationprovisioner during startup and app removal.
hpidcock e0e3c96
Fix handling of errors for UnitIntroduction.
hpidcock a8f5462
Fix missing copyright statement
hpidcock 9c47857
Add provisioning state to application for caasapplicationprovisioner …
hpidcock 8a52ce4
Improve unit introduction within state.
hpidcock 32459be
Remove GarbageCollect used by caasapplicationprovisioner + extra logs.
hpidcock 8ae2c6e
Enable public.ecr.aws
hpidcock 851208c
Cleanup + fix unit tests for sidecar teardown.
hpidcock cb35703
Fix linter issues.
hpidcock e75fac5
Merge branch '2.9' into teardown-2.0
hpidcock d68eabb
Improve storage reattachment for sidecar charms + storage destroy log…
hpidcock 0c9a426
Start of refactor of caasapplicationprovisioner for better testing.
hpidcock c50b562
caasapplicationprovisioner operation tests.
hpidcock 1c22212
Add full caasapplicationprovisioner application worker test.
hpidcock 8df6cc6
Add test for UpsertCAASUnit
hpidcock ca077ae
Implement migration and fix tests.
hpidcock 1672b51
Use juju-qa-fixed-rev for refresh integreation test
jack-w-shaw 1a2759d
Merge pull request #15636 from jack-w-shaw/JUJU-3822_replace_ubuntu_w…
jujubot 2bb76c9
Adds tls-certificates-operator to fix mattermost-k8s.
anvial 524980b
Switch to 'juju-qa-dummy-sink' and 'juju-qa-dummy-source' charms.
anvial 097abc1
Use juju-qa-test rather than postgres
SimonRichardson c316413
Merge pull request #15650 from SimonRichardson/fix-machine-test-logs-aws
jujubot e2d4dd7
Replace deprecated yq -j flag with -o=j
barrettj12 4436840
Merge pull request #15652 from barrettj12/ojson
jujubot 870f6c7
[bash tests] print controller teardown logs
barrettj12 ee886dd
Merge pull request #15653 from barrettj12/teardown-logs
jujubot 0bb6df2
Merge pull request #15633 from anvial/JUJU-3821-fix-test-deploy-aks-c…
jujubot 682a4b0
Adds BOOTSTRAP_PROVIDER=k8s before aks-controller boostraping.
anvial f16dd80
Merge pull request #15657 from anvial/JUJU-3842-fix-deploy-aks-clean-…
jujubot f98085e
Ignore failure on `aws ec2 delete-network-interface`
hpidcock 686b6f2
Merge pull request #15660 from hpidcock/ignore-delete-network-interface
jujubot 6841e1b
Fix data race in GetOSFromSeries
hpidcock c75361d
Fix relation departing test waiting.
hpidcock f639f09
Merge pull request #15661 from hpidcock/fix-data-race-getosfromseries
jujubot 68ef945
Merge pull request #15662 from hpidcock/fix-relation-departing-test
jujubot 4f1418a
Fix test-branch by using a simple charm.
hpidcock c14bcb3
Merge pull request #15663 from hpidcock/fix-test-branch
jujubot 619ae83
Fix storage-attached hook that was requeued.
hpidcock 4f58067
Fix ApplicationWorkerSuite.TestWorker flapping.
hpidcock 0d62596
Fix LifeFlag watcher client test.
hpidcock f747552
Updates life flag not found error.
tlm 5d23dcc
Adds missing tests for DestroyUnits.
tlm 6e14eda
Update error name for life flag.
tlm cb6e938
Apply feedback to caas sidecar teardown.
hpidcock 52f4bee
Fix storage not provisioned in TestNewHookRunnerWithStorage
hpidcock 25ea0ca
Update juju/descriptions/v3
hpidcock 1be46d0
Fix error handling for storage + PR feedback.
hpidcock 0ab55fd
Fix uniter remotestate storage tests.
hpidcock 243fd66
Merge pull request #15313 from tlm/teardown-2.0
jujubot a6e567b
Merge branch '2.9' into merge-2.9-3.1-sidecar-teardown
hpidcock 90bc277
Fix non-microk8s cloud finding (e.g. minikube, from kubeconfig)
hpidcock e7596ce
Fix merge and regenerate mocks.
hpidcock a35072d
Fix TestUpsertCAASUnit
hpidcock 54b093c
Fix controller terminating due to caasapplicationprovisioner.
hpidcock File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
// Copyright 2023 Canonical Ltd. | ||
// Licensed under the AGPLv3, see LICENCE file for details. | ||
|
||
package lifeflag | ||
|
||
import ( | ||
"github.com/juju/names/v4" | ||
|
||
"github.com/juju/juju/api/base" | ||
"github.com/juju/juju/api/common/lifeflag" | ||
"github.com/juju/juju/core/life" | ||
"github.com/juju/juju/core/watcher" | ||
) | ||
|
||
// Client is the client used for connecting to the life flag facade. | ||
type Client interface { | ||
Life(names.Tag) (life.Value, error) | ||
Watch(names.Tag) (watcher.NotifyWatcher, error) | ||
} | ||
|
||
// NewClient creates a new life flag client. | ||
func NewClient(caller base.APICaller) Client { | ||
return lifeflag.NewClient(caller, "AgentLifeFlag") | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could have used
apiservererrors.RestoreError()
hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will handle in 2.9