networker API facade #16
Conversation
| IsVirtual bool | ||
| } | ||
|
|
||
| func (i *Info) ActualInterfaceName() string { |
There was a problem hiding this comment.
Not to bikeshed too much, but would these be better as RawInterfaceName and func InterfaceName() ?
There was a problem hiding this comment.
The whole point of this change is to make it easier to transition state-stored networks and interfaces for a machine into an API method result, keeping the same order and data in there. And this is enough for now for the networker to do its job. There were too many discussions on this already, let's not go back but forward with what we agreed upon please.
There was a problem hiding this comment.
Please, add a doc comment to ActualInterfaceName, as it's exported.
|
I think this is looking pretty good. I'd like to have Dimiter look it over, though. John |
| c.Assert(s.networker, gc.NotNil) | ||
|
|
||
| // Expected results of MachineNetworkInfo for a machine and a containers | ||
| s.expectedMachineInfo = []network.Info{{ |
There was a problem hiding this comment.
Why is this here? It should be in the actual test I think, not SetUpTest.
There was a problem hiding this comment.
It's quite nice having it near the data that it needs to match, though. I'm still +1 on splitting this up, it might well help.
There was a problem hiding this comment.
I moved all expectedResult struct to tests
| return false | ||
| } | ||
| for parentId := state.ParentId(id); parentId != ""; parentId = state.ParentId(parentId) { | ||
| // Until reach top-level machine. |
There was a problem hiding this comment.
s/Until reach/Until we reach/ or Until a top-level machine is reached?
|
Thanks, much better now - LGTM with just a few minor things to fix. |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
|
|
|
api: new Networker API facade The original task was: "new Networker API facade (client/server) with ListVLANsForMachine API call" The additional tas was: "Networker API" should do all network setup staff done by cloud-init But all thing are changing and now Networker API has the only method calld MachineNetworkInfo(machineTag string) ([]network.Info, error).
Demo code to set block devices in state
Patch juju#2049 diff from master (remove obsolete AddMetrics API)
Added "actions" location to wordpress test charm
state: add support for CAAS FindEntity and User.
Updated dependencies to enable extra-bindings from charm metadata to be honored for bundle deployments No other changes than updating dependencies.tsv needed.
Filter machines Based on unlanded PR juju#15
Update all dependencies
api: new Networker API facade
The original task was:
"new Networker API facade (client/server) with ListVLANsForMachine API call"
The additional tas was:
"Networker API" should do all network setup staff done by cloud-init
But all thing are changing and now Networker API has the only method calld
MachineNetworkInfo(machineTag string) ([]network.Info, error).