[JUJU-4619] Missing oracle cloud regions and list not being updated #16287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds 51 new region for Oracle cloud provider. Regions list was taken from `oci` cli-tool output.
hmlanigan
requested changes
Sep 19, 2023
There was a problem hiding this comment.
QA has a failure, I did a juju bootstrap oci-canonical/us-ashburn-1 and the controller was still created in Phoenix, which is the default. Same for added models, cloud/region works
$ juju add-model five oci-canonical/us-ashburn-1
Added 'five' model on oci-canonical/us-ashburn-1 with credential 'default' for user 'admin'
But region only, per the juju add-model --help fails.
$ juju add-model five us-luke-1
ERROR cloud us-luke-1 not found
Use 'juju clouds' to see a list of all available clouds or 'juju add-cloud' to a add one.
Even though I added a model in us-ashburn-1, machine appeared in us-phoenix-1 region.
This commit removes the gov regions, if needed we will add them as saparate clouds (like did with AWS).
anvial
force-pushed
the
JUJU-4619-missing-oracle-cloud-regions-and-list-not-being-updated
branch
from
90dbbc7
to
9d31376
Compare
hmlanigan
approved these changes
Oct 20, 2023
|
/merge |
anvial
changed the title
Merged
Merged
jujubot
added a commit
that referenced
this pull request
Oct 25, 2023
Merged
jujubot
added a commit
that referenced
this pull request
Oct 25, 2023
#16498 Forward merges: - #16459 - #16467 - #16473 - #16474 - #16475 - #16476 - #16393 - #16480 - #16481 - #16287 - #16477 - #16486 - #16434 - #16487 - #16488 - #16491 - #16492 - #16494 - #16489 - #16497 Conflicts: - api/client/machinemanager/machinemanager.go - api/client/machinemanager/machinemanagernew_test.go - apiserver/facades/client/modelconfig/modelconfig.go - apiserver/facades/client/modelconfig/modelconfig_test.go - apiserver/stateauthenticator/context.go - cmd/juju/application/refresh_test.go - scripts/win-installer/setup.iss - snap/snapcraft.yaml - version/version.go Mostly trivially solved. `cmd/juju/application/refrest_test.go` was the only one that required any original code. Verify by ensuring unit tests pass
anvial
deleted the
JUJU-4619-missing-oracle-cloud-regions-and-list-not-being-updated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 51 new region for Oracle cloud provider. Regions list was taken from
ocicli-tool output.Checklist
QA steps
Commands to run to verify that the change works.
go test github.com/juju/juju/cloud/... -gocheck.v juju regions oracleLinks
Launchpad bug: https://pad.lv/2031468
Jira card: JUJU-4619