Allow building with podman using make OCI_BUILDER=podman ...
#16380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
approved these changes
Oct 5, 2023
wallyworld
reviewed
Oct 5, 2023
tlm
approved these changes
Oct 6, 2023
|
/merge |
Merged
jujubot
added a commit
that referenced
this pull request
Oct 10, 2023
#16406 Forward ports: - #16380 - #16390 - #16374 Conflicts: - .github/workflows/static-analysis.yml - Makefile - apiserver/facades/client/controller/controller.go - apiserver/facades/controller/caasmodelconfigmanager/register.go - cmd/juju/commands/bootstrap.go - controller/config_test.go - docker/auth_test.go - provider/equinix/environ.go
Merged
jujubot
added a commit
that referenced
this pull request
Oct 10, 2023
#16409 Forward ports: - #16380 - #16390 - #16365 - #16374 - #16405 - #16406 - #16408 Conflicts: - .github/workflows/static-analysis.yml - Makefile - apiserver/facades/controller/caasmodelconfigmanager/facade.go - cmd/containeragent/initialize/package_test.go - controller/config.go - controller/config_test.go - provider/equinix/environ.go
Merged
Merged
jujubot
added a commit
that referenced
this pull request
Oct 12, 2023
#16415 Forward ports: - #16380 - #16390 - #16365 - #16374 - #16405 - #16406 - #16408 - #16409 - #16403 - #16411 - #16412 - #16410 Conflicts: - apiserver/facades/client/client/client.go - 🚩 **apiserver/facades/client/controller/controller.go** - apiserver/facades/client/controller/controller_test.go - apiserver/facades/controller/caasapplicationprovisioner/provisioner.go - apiserver/facades/controller/caasmodelconfigmanager/register.go - apiserver/facades/controller/caasmodeloperator/operator.go - apiserver/facades/controller/caasoperatorprovisioner/provisioner.go - apiserver/facades/controller/caasunitprovisioner/provisioner.go - caas/kubernetes/provider/bootstrap_test.go - cmd/containeragent/initialize/package_test.go - controller/config.go - controller/config_test.go - internal/docker/auth.go - worker/caasmodelconfigmanager/worker.go - worker/caasmodelconfigmanager/worker_test.go Changes: - api/controller/caasmodelconfigmanager/client.go - 🚩 **apiserver/facades/controller/caasmodelconfigmanager/facade.go** - apiserver/facades/schema.json - caas/kubernetes/provider/bootstrap.go - cloudconfig/podcfg/image.go - cmd/juju/commands/bootstrap.go - worker/caasmodelconfigmanager/mocks/facade_mock.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow building with podman using
make OCI_BUILDER=podman ...QA steps
make microk8s-operator-updateshould use dockermake OCI_BUILDER=podman microk8s-operator-updateshould use podmanDocumentation changes
N/A
Links
N/A