Filter out icmpv6 when reading back ec2 security groups. #16383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best way to test this is to bootstrap with the following:
You can then confirm from the logs that we are not seeing the firewater crash from reading in the icmpv6 rules. I have tested this on my end and can't see any issues. |
|
We should loop back around soon and give Juju icmpv6 support. That would be the best outcome. |
|
/merge |
Merged
jujubot
added a commit
that referenced
this pull request
Oct 9, 2023
#16399 Merges: - #16321 - #16361 - #16373 - #16387 - #16386 - #16389 - #16391 - #16398 - #16383 - #16366 Conflicts: - upgrades/operations.go - upgrades/upgrade_test.go All conflicts from #16366. Arising simply from the version number in upgrade_steps I also needed to rename steps_317.go to steps_324.go
Merged
jujubot
added a commit
that referenced
this pull request
Oct 9, 2023
#16401 Merges: - #16354 - #16321 - #16361 - #16373 - #16377 - #16387 - #16386 - #16389 - #16392 - #16391 - #16398 - #16383 - #16366 - #16399 Conflicts: - state/upgrades.go - state/upgrades_test.go - upgrades/backend.go - upgrades/operations.go - upgrades/upgrade_test.go All conflicts resulting from #16366 Since this is an unreleased minor version, we do not need upgrade steps (there is nowhere to upgrade from), so drop them
Merged
jujubot
added a commit
that referenced
this pull request
Oct 11, 2023
#16407 Merge `3.3` into `main`: - #16354 - #16321 - #16361 - #16373 - #16377 - #16387 - #16389 - #16392 - #16391 - #16398 - #16383 - #16366 - #16367 - #16382 ``` # Conflicts: # apiserver/facades/client/application/application_unit_test.go # apiserver/facades/client/secrets/secrets.go # apiserver/facades/controller/caasoperatorprovisioner/provisioner_test.go # apiserver/facades/controller/caasunitprovisioner/provisioner_test.go # caas/kubernetes/provider/application/application_test.go # caas/kubernetes/provider/k8s_test.go # caas/kubernetes/provider/operator_test.go # internal/docker/registry/internal/gitlab.go # state/secrets_test.go ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firewaller is crashing when trying to read rules out of the ec2 provider.
This is due to #16061 adding in the minimum icmpv6 rules for proper v6 support in aws that should, until juju models this better, be hidden from the firewaller.
QA steps
@tlm how best to test this?
Documentation changes
N/A
Links
https://jenkins.juju.canonical.com/job/test-deploy-test-deploy-bundles-aws/3336/