Fix parsing of watch flag on status command

[nvinuesa]

On the status command, when passing the --watch flag, we pass the entire command line arguments (including 'juju status') along with all the flags except --watch to viddy, which will run the command indefinitely with an interval.

To do this, we must remove the --watch flag along with its value from the list of OS arguments to be passed to viddy. This was incorrectly done because it only accepted unix-style flags.

The fix is to remove both unix and gnu style when passing the watch flag.

Checklist

• Code style: imports ordered, good names, simple structure, etc
• Comments saying why design decisions were made
• Go unit tests, with comments saying what you're testing
• Integration tests, with comments saying what you're testing
• doc.go added or updated in changed packages

QA steps

After bootstrapping and adding a model, get the status with --watch on two different styles:

juju status --watch 1s --relations
juju status --watch=1s --relations  

also,

go test github.com/juju/juju/cmd/juju/status/... -gocheck.v

Links

Launchpad bug: https://bugs.launchpad.net/juju/+bug/2037914

Jira card: JUJU-4782

[SimonRichardson]

Can you check that -w=1s still works?

[nvinuesa]

@SimonRichardson has the -w flag ever worked? I'm testing on 3.1 and it doesn't

[jack-w-shaw]

I'm not aware of -w being supported either. Perhaps in 2.9?

[jack-w-shaw]

LGTM

[jack-w-shaw]

This is a side effect. I'm guessing the reason we have this here is to ensure we pass --color to ensure color is explict for viddy to avoid bugs? The fact it isn't obvious is a smell

Perhaps we should rename the function to statusCommandForViddy or something?

[nvinuesa]

done

[SimonRichardson]

We definitely do support single character shortcut, so that also needs fixing

[nvinuesa]

@SimonRichardson we do support single char shortcut but only for some of the flags:

Summary:
Report the status of the model, its machines, applications and units.

Global Options:
--debug  (= false)
    Equivalent to --show-log --logging-config=<root>=DEBUG
-h, --help  (= false)
    Show help on a command or other topic.
--logging-config (= "")
    Specify log levels for modules
--quiet  (= false)
    Show no informational output
--show-log  (= false)
    If set, write the log file to stderr
--verbose  (= false)
    Show more verbose output

Command Options:
-B, --no-browser-login  (= false)
    Do not use web browser for authentication
--color  (= false)
    Use ANSI color codes in tabular output
--format  (= tabular)
    Specify output format (json|line|oneline|short|summary|tabular|yaml)
--integrations  (= false)
    Show 'integrations' section in tabular output
-m, --model (= "")
    Model to operate in. Accepts [<controller name>:]<model name>|<model UUID>
--no-color  (= false)
    Disable ANSI color codes in tabular output
-o, --output (= "")
    Specify an output file
--relations  (= false)
    The same as '--integrations'
--retry-count  (= 3)
    Number of times to retry API failures
--retry-delay  (= 100ms)
    Time to wait between retry attempts
--storage  (= false)
    Show 'storage' section in tabular output
--utc  (= false)
    Display timestamps in the UTC timezone
--watch  (= 0s)
    Watch the status every period of time

and watch is not one of them

[nvinuesa]

/merge