Fixes deploying controller charm on Kubernetes. #16507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix set IsControllerCloud on the cloud object established during bootstrap from params. Without this the state policy that we wire up won't be able to construct a Kubernetes environ. This is a really ugly fix but it can go with Mongo. Fixes lp2040947
wallyworld
approved these changes
Oct 27, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix set IsControllerCloud on the cloud object established during bootstrap from params. Without this the state policy that we wire up won't be able to construct a Kubernetes environ.
This is a really ugly fix but it can go with Mongo.
Fixes lp2040947
Why this change is needed and what it does.
Checklist
If an item is not applicable, use
~strikethrough~.[ ] Go unit tests, with comments saying what you're testing[ ] Integration tests, with comments saying what you're testing[ ] doc.go added or updated in changed packagesQA steps
Get "https://127.0.0.1:16443/api/v1/namespaces?labelSelector=model.juju.is%2Fname%3Dcontroller": dial tcp 127.0.0.1:16443: connect: connection refusedjuju switch controllerthenjuju statusto confirm that the controller charm is deployed.Documentation changes
N/A
Links
Launchpad bug: https://bugs.launchpad.net/juju/+bug/2040947
Jira card: JUJU-4883
Insert other relevant links here.