Fail actions which are interrupted due to an agent restart in the middle #16922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/merge |
Merged
jujubot
added a commit
that referenced
this pull request
Feb 20, 2024
#16939 There were no merge conflicts from this, the commits added are: #16844 Support minikube env folder on juju snap. #16876 Pass all the availability zones when discovering subnets in clustered lxd. #16890 Revert dot-minikube on snapcraft until auto-connect is approved. #16567 Add lease manager worker documentation. #16898 Suppress klog log messages. #16905 Ensure we close client. #16915 Merge branch '3.1' of https://github.com/juju/juju into 3.1-into-3.3. #16917 Fix docker cache for github actions. #16922 Fail actions which are interrupted due to an agent restart in the middle. #16930 Fix the HasModelAdmin API to handle non admins properly. #16936 Merge branch '2.9' into merge-2.9-3.1. #16937 Merge branch '3.1' into merge-3.1-3.3. #16938 Add check for relation-get with app arguemnt but no --app flag.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a unit agent is killed and restarted in the middle of running an action, the action stays forever in the running state. This is because the unit agent was not running the FailAction operation to mark the action as failed and hence terminate it. In addition, the commit operation at the end of the fail action was not wired up to correctly update local state to remove the action from the "todo" list.
QA steps
run an action like so
juju exec -u someunit/0 -- "echo hello; reboot"After a few seconds for the machine to reboot, the CLI will exit back to a shell prompt (it blocks in the meantime).
The action is failed, and
juju show-task <n> --format yamlshows the action was terminated and marked as failed.Previously the CLI would block forever and the action would stay in the running state.
Links
https://bugs.launchpad.net/juju/+bug/2012861
Jira card: JUJU-5438