Add extra uniter debugging for resolving next actions #17051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
force-pushed
the
extra-actions-logging
branch
from
b0ca066
to
b0cac35
Compare
SimonRichardson
approved these changes
Mar 18, 2024
|
/merge |
Merged
jujubot
added a commit
that referenced
this pull request
Mar 21, 2024
#17074 Merge 3.3 #17005 [from Aflynn50/2.9-with-charm-fix](9ad3425) #17047 [from hpidcock/fix-podman-push](9d06ec5) #17050 [from hmlanigan/nil-ptr-space-does-not-exist](6ca7753) #17051 [from wallyworld/extra-actions-logging](30cc829) #17035 [from Aflynn50/ssh-bug-fix-3.3](6fce647) #17071 [from wallyworld/opimise-model-upgrades](0e9268a) ``` # Conflicts: # go.sum # ```
Merged
jujubot
added a commit
that referenced
this pull request
Apr 9, 2024
#17168 Forward merge: - #17050 - #17051 - #17035 - #17066 - #17071 - #17073 - #17074 - #17077 - #17078 - #17083 - #17085 - #17087 - #17088 - #17090 - #17094 - #17095 - #17096 - #17092 - #17101 - #17109 Conflicts: - api/controller/crossmodelrelations/crossmodelrelations.go - apiserver/facades/client/keymanager/keymanager.go - apiserver/facades/client/modelupgrader/upgrader.go - apiserver/facades/client/modelupgrader/upgrader_test.go - cmd/modelcmd/base.go - go.mod - go.sum - internal/worker/remoterelations/remoteapplicationworker.go - internal/worker/uniter/resolver.go - state/migration_export.go Conflicts were mostly resolved trivially, as they were a result of contexts being added to all faacdes. Keymanager was slightly more difficult. There are 4 unit test failures in `github.com/juju/juju/apiserver/facades/client/keymanager` which I have not been able to resolve. @Aflynn50 could you take a look?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added extra logging around how the unit agent resolves next operations to run, and in particular actions.
We've has cases of actions getting stuck and not enough logging to understand why. This extra logging might help next time it happens.
QA steps
deploy a k8s charm and run an action on it
Links
Jira card: JUJU-5685