Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add condition for handling empty security groups #17105

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Add condition for handling empty security groups #17105

merged 1 commit into from
Mar 26, 2024

Conversation

anvial
Copy link
Member

@anvial anvial commented Mar 26, 2024

This PR introduces a new condition to handle scenarios where the security group is empty. This enhances the robustness of our security group handling logic and prevents potential errors due to empty security groups.

Checklist

  • Code style: imports ordered, good names, simple structure, etc
  • Comments saying why design decisions were made
  • Go unit tests, with comments saying what you're testing
  • Integration tests, with comments saying what you're testing
  • doc.go added or updated in changed packages

QA steps

cd tests
./main.sh -v -c aws firewall test_expose_app_ec2

Links

Jira card: JUJU-

@anvial
Add condition for handling empty security groups
99faf8b 
This commit introduces a new condition to handle scenarios where the security group is empty.
This enhances the robustness of our security group handling logic and prevents potential errors
due to empty security groups.
nvinuesa
nvinuesa approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@nvinuesa nvinuesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@anvial
Copy link
Member Author

anvial commented Mar 26, 2024

/merge

@jujubot jujubot merged commit d52737e into juju:3.3 Mar 26, 2024
7 of 8 checks passed
@anvial anvial mentioned this pull request Mar 27, 2024
Merged
jujubot added a commit that referenced this pull request Mar 27, 2024
@jujubot
Merge pull request #17112 from anvial/3.3-to-3.4-merge-20240327
fd1226a 
#17112

No conflicts.

- d52737e (origin/3.3, 3.3) Merge pull request #17105 from anvial/add-condition-for-empty-sg
@jack-w-shaw jack-w-shaw mentioned this pull request Apr 9, 2024
Merged
jujubot added a commit that referenced this pull request Apr 10, 2024
@jujubot
Merge pull request #17175 from jack-w-shaw/3.4-into-3.5
1c40051 
#17175

Forward merge:
- #17105
- #17112
- #17117
- #17139
- #17152
- #17158
- #17167

Conflicts:
- go.mod
- go.sum
- scripts/win-installer/setup.iss
- snap/snapcraft.yaml
- version/version.go

i.e. the usual version conflicts (solved by selecting the 3.5 version) and dependency (resolved by picking the largest version)
@jack-w-shaw jack-w-shaw mentioned this pull request Apr 10, 2024
Merged
jujubot added a commit that referenced this pull request Apr 11, 2024
@jujubot
Merge pull request #17182 from jack-w-shaw/3.5-into-main
3ee4962 
#17182

Merges:
- #17105
- #17117
- #17139
- #17152
- #17158
- #17118
- #17167
- #17175

Conflicts:
- internal/provider/vsphere/image_metadata.go
- internal/provider/vsphere/vm_template.go

Conflicts resulted from the usual context change. Resolved trivially
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvinuesa nvinuesa nvinuesa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@anvial @nvinuesa @jujubot