Fix returned errors on network domain state layer #17291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes two cases on which the wrong error was returned from the state layer on the network domain, meaning that the service layer wasn't handling those correctly.
The first one is when trying to add a subnet with the same provider-id (this happens when reloading spaces twice on a row for example). The second one is when trying to remove spaces that don't contain a provider id, this should not prevent the delete.
Checklist
Integration tests, with comments saying what you're testingdoc.go added or updated in changed packagesQA steps
Bootstrap, reload spaces twice. Then add a space and remove it. There should be no errors.
Links
Jira card: JUJU-