Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused series test funcs #17414

Merged
merged 1 commit into from
May 24, 2024
Merged

Remove unused series test funcs #17414

merged 1 commit into from
May 24, 2024

Conversation

jack-w-shaw
Copy link
Member

Since main, we no longer use these test functions anywhere

Since they return series, we should remove them

QA Steps

All unit tests pass

nvinuesa
nvinuesa approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@nvinuesa nvinuesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, weird PR description template though 🤣

@jack-w-shaw
Copy link
Member Author

/merge

@jujubot jujubot merged commit 223260b into juju:main May 24, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvinuesa nvinuesa nvinuesa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jack-w-shaw @nvinuesa @jujubot