Fix os version #186
Merged
Fix os version #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM I think |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Jun 27, 2014
Fix os version
Fix Lp 1334493
Remove all the double underpants // +build tags, the os is inferred from the name of the file.
Remove osversion_unknown.go, Juju cannot operate without knowing the series of the machine, so cause a compilation failure, rather than produce tools that explode on use.
lucky(~/src/github.com/juju/juju/version) % GOOS=windows go list -f '{{.GoFiles}}'
[osversion.go osversion_windows.go supportedseries.go version.go]
lucky(~/src/github.com/juju/juju/version) % GOOS=linux go list -f '{{.GoFiles}}'
[osversion.go osversion_linux.go supportedseries.go version.go]
lucky(~/src/github.com/juju/juju/version) % GOOS=darwin go list -f '{{.GoFiles}}'
[osversion.go osversion_darwin.go supportedseries.go version.go]
laszlokajtar
pushed a commit
to laszlokajtar/juju
that referenced
this pull request
Oct 25, 2023
Add sdk docs to juju.is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Lp 1334493
Remove all the double underpants // +build tags, the os is inferred from the name of the file.
Remove osversion_unknown.go, Juju cannot operate without knowing the series of the machine, so cause a compilation failure, rather than produce tools that explode on use.
lucky(
/src/github.com/juju/juju/version) % GOOS=windows go list -f '{{.GoFiles}}'/src/github.com/juju/juju/version) % GOOS=linux go list -f '{{.GoFiles}}'[osversion.go osversion_windows.go supportedseries.go version.go]
lucky(
[osversion.go osversion_linux.go supportedseries.go version.go]
lucky(~/src/github.com/juju/juju/version) % GOOS=darwin go list -f '{{.GoFiles}}'
[osversion.go osversion_darwin.go supportedseries.go version.go]