WIP State level WatchInterfaces #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 25, 2014 14:43
| wc.AssertOneChange() | ||
|
|
||
| // Disable the first interface. | ||
| err = ifaces[0].SetDisabled(true) |
There was a problem hiding this comment.
FWIW, I would generally prefer to see positive terms than negative ones -- !disabled is a really cumbersome way to write "enabled", compared to !enabled for "disabled".
added 2 commits
July 1, 2014 12:07
| return results.Results[0].Info, nil | ||
| } | ||
|
|
||
| // WatchInterfaces returns a NotifyWatcher that notifies of changes of network |
|
Looks almost ready, apart from a couple issues with the tests. |
added 2 commits
July 1, 2014 16:11
|
LGTM, thank you! |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
|
|
Build failed: Some weird error with not finding the landing script, probably transitory: /tmp/hudson6827171313236674227.sh: line 121: /home/ubuntu/jenkins-github-lander/bin/lander-merge-result: No such file or directory |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Jul 2, 2014
WIP State level WatchInterfaces Wraps the State level WatchInterfaces watcher, and maps the Ids we get from state into Tags for the API. This also includes exposing the WatchInterfaces call in the API, so touching state/apiserver and state/api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps the State level WatchInterfaces watcher, and maps the Ids we get from state into Tags for the API.
This also includes exposing the WatchInterfaces call in the API, so touching state/apiserver and state/api