Added two more tests for multiple and no api-endpoints #211
Conversation
|
|
||
| // modifyAddresses adds more endpoint addresses or removes all | ||
| // in case of nil. | ||
| func (s *EndpointSuite) modifyAddresses(c *gc.C, addresses []string) { |
There was a problem hiding this comment.
I find such function confusing: adds more endpoint addresses or removes all in case of nil.
The two separate function would be more appropriate here.
But even if we stay the above function, I would do nothing if called modifyAddresses(c, []string{}),
and delete all addresses only if called modifyAddresses(c, nil).
Anyway, the current comment is invalid, because now all addresses are removed in case of []string{}, too.
There was a problem hiding this comment.
Seems a fair point. What if we just simplify all of it to a simple "setAPIAddresses". And then we can call it with an empty list, or with a known list.
We just move the call to s.APIInfo() a bit earlier, and then do:
s.setAPIAddresses(c, []string{info.Addrs[0], "0.1.2.3...", "0.1.2.3..."})
|
I think you could go with a setAPIAddresses, and then it LGTM. |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Added two more tests for multiple and no api-endpoints Added two more api-endpoint test cases for multiple endpoints (and using only the first one) and no endpoints (so automatically refresh and return the first endpoint then).
…torials Implement filters on tutorials page
Added two more api-endpoint test cases for multiple endpoints (and using only the first one) and no endpoints (so automatically refresh and return the first endpoint then).