Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongo: don't treat apt-get failures as fatal #2184

Merged
merged 1 commit into from
May 6, 2015

Conversation

mjs
Copy link

@mjs mjs commented May 1, 2015

If installation/upgrade of Juju's MongoDB package fails, continue anyway as it's likely a workable package is already installed. Problems with the packaging system shouldn't prevent jujud
from starting.

Fixes LP #1441904.

(Review request: http://reviews.vapour.ws/r/1546/)

If installation/upgrade of Juju's MongoDB package fails, continue
anyway as it's likely a workable package is already
installed. Problems with the packaging system shouldn't prevent jujud
from starting.

Fixes LP #1441904.
@mjs
Copy link
Author

mjs commented May 6, 2015

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented May 6, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request May 6, 2015
mongo: don't treat apt-get failures as fatal

If installation/upgrade of Juju's MongoDB package fails, continue anyway as it's likely a workable package is already installed. Problems with the packaging system shouldn't prevent jujud
from starting.

Fixes LP #1441904.

(Review request: http://reviews.vapour.ws/r/1546/)
@jujubot jujubot merged commit 0c0a4d4 into juju:master May 6, 2015
@mjs mjs deleted the 1441904-mongodb-apt-get branch May 6, 2015 04:34
@davecheney
Copy link
Contributor

No code review ?

On Wed, May 6, 2015 at 1:52 PM, Juju bot notifications@github.com wrote:

Status: merge request accepted. Url:
http://juju-ci.vapour.ws:8080/job/github-merge-juju


Reply to this email directly or view it on GitHub
#2184 (comment).

@wallyworld
Copy link
Member

We don't generally need reviews for forward ports of previously reviewed PR's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants