Forward port of pull request #2258 from natefinch/fix-1452285 #2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foward port from PR #2258 revamp log rotation This fixes https://bugs.launchpad.net/juju-core/+bug/1452285 The problem was that we had moved the log rotation code earlier in the startup code, and then other code overwrote what loggo used as a default writer. This code consolidates the loggo-modification code to a single place, so we don't have to worry about that anymore. (Review request: http://reviews.vapour.ws/r/1619/) Conflicts: agent/agent.go cmd/jujud/agent/agent.go cmd/jujud/agent/agent_test.go cmd/jujud/agent/machine_test.go
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
May 13, 2015
Forward port of pull request #2258 from natefinch/fix-1452285 Foward port from PR #2258 revamp log rotation This fixes https://bugs.launchpad.net/juju-core/+bug/1452285 The problem was that we had moved the log rotation code earlier in the startup code, and then other code overwrote what loggo used as a default writer. This code consolidates the loggo-modification code to a single place, so we don't have to worry about that anymore. (Review request: http://reviews.vapour.ws/r/1619/) Conflicts: agent/agent.go cmd/jujud/agent/agent.go cmd/jujud/agent/agent_test.go cmd/jujud/agent/machine_test.go (Review request: http://reviews.vapour.ws/r/1666/)
jujubot
added a commit
that referenced
this pull request
May 13, 2015
Merge pull request #2303 from natefinch/fix-1452285-1.24 Forward port of pull request #2303 from natefinch/fix-1452285-1.24 revamp log rotation This fixes https://bugs.launchpad.net/juju-core/+bug/1452285 The problem was that we had moved the log rotation code earlier in the startup code, and then other code overwrote what loggo used as a default writer. This code consolidates the loggo-modification code to a single place, so we don't have to worry about that anymore. (Review request: http://reviews.vapour.ws/r/1668/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foward port from PR #2258
revamp log rotation
This fixes https://bugs.launchpad.net/juju-core/+bug/1452285
The problem was that we had moved the log rotation code earlier in the startup code, and then other code overwrote what loggo used as a default writer. This code consolidates the loggo-modification code to a single place, so we don't have to worry about that anymore.
(Review request: http://reviews.vapour.ws/r/1619/)
Conflicts:
agent/agent.go
cmd/jujud/agent/agent.go
cmd/jujud/agent/agent_test.go
cmd/jujud/agent/machine_test.go
(Review request: http://reviews.vapour.ws/r/1666/)