Fixed lp:1442257 - port of #2366 to 1.25 #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| container.ConfigName: "juju", | ||
| container.ConfigLXCDefaultMTU: "9000", | ||
|
|
||
| "use-aufs": "false", |
There was a problem hiding this comment.
Sadly no constant when this setting has been introduced.
|
LGTM 👍 |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1457031'] |
|
the blocker is Fix Committed, so |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1457031'] |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
May 21, 2015
Fixed lp:1442257 - port of #2366 to 1.25 This includes 2 fixes for 1.25: * http://pad.lv/1442257 - instead of inheriting LXC containers' host's primary NIC's MTU value for container NICs, now we have an optional integer environment setting "lxc-default-mtu", which when set to a positive number will cause all LXC (but not KVM) NICs to use that MTU. This is a straightforward port of #2365 to 1.25. * Related, but not a fix for http://pad.lv/1443942 (originally proposed as #2190 but it didn't land in time) - only add iptables SNAT rules on the container hosts for EC2 environments, as this breaks MAAS and it's not needed (fallout from the original fix #2071 for bug http://pad.lv/1442801). Live tested on MAAS and EC2 with the following configurations: * bootstrap on trusty, add a precise node * bootstrap on precise, add a trusty node * in both cases above, do a test with and without the address-allocation feature flag * deploy workloads and relate them in LXC and KVM More unit tests around the enableNAT logic will be added later, as described bug lp:1443942.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes 2 fixes for 1.25:
primary NIC's MTU value for container NICs, now we have an optional
integer environment setting "lxc-default-mtu", which when set to a
positive number will cause all LXC (but not KVM) NICs to use that
MTU. This is a straightforward port of Fixed lp:1442257 - lxc-default-mtu environ setting added #2365 to 1.25.
as +address-allocation ff: don't use SNAT for LXC/KVM on MAAS #2190 but it didn't land in time) - only add iptables SNAT rules
on the container hosts for EC2 environments, as this breaks MAAS and
it's not needed (fallout from the original fix Mangle source IP address for EC2 traffic that leaves the VPC - fixes LXC on EC2 #2071 for bug
http://pad.lv/1442801).
Live tested on MAAS and EC2 with the following configurations:
feature flag
More unit tests around the enableNAT logic will be added later,
as described bug lp:1443942.