Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fixed lp:1442257 - port of #2366 to 1.25 #2392
Conversation
themue
reviewed
May 21, 2015
| + container.ConfigName: "juju", | ||
| + container.ConfigLXCDefaultMTU: "9000", | ||
| + | ||
| + "use-aufs": "false", |
|
LGTM |
|
$$fixes-1442257$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1457031'] |
|
the blocker is Fix Committed, so $$JFDI$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1457031'] |
|
$$JFDI$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
May 21, 2015
jujubot
merged commit fd6d4ed
into
juju:master
May 21, 2015
dimitern
deleted the
dimitern:lp-1442257-1.25
branch
May 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dimitern commentedMay 21, 2015
This includes 2 fixes for 1.25:
primary NIC's MTU value for container NICs, now we have an optional
integer environment setting "lxc-default-mtu", which when set to a
positive number will cause all LXC (but not KVM) NICs to use that
MTU. This is a straightforward port of #2365 to 1.25.
as #2190 but it didn't land in time) - only add iptables SNAT rules
on the container hosts for EC2 environments, as this breaks MAAS and
it's not needed (fallout from the original fix #2071 for bug
http://pad.lv/1442801).
Live tested on MAAS and EC2 with the following configurations:
feature flag
More unit tests around the enableNAT logic will be added later,
as described bug lp:1443942.