1286518 log perms 2 #245
Merged
1286518 log perms 2 #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-perms-2 Conflicts: environs/cloudinit/cloudinit_test.go
|
LGTM although I dont really understand the full extent of the changes, mostly where exec is changed for script, I would like if someone else takes a look (also, if you think there is a slight possibility that this needs to be reverted by any issue, it would be a good idea to squash the changes into one to make it easy to look for in master. |
|
Thanks perrito666. A little background to help you feel more comfortable: in Upstart, apparently there can only be one exec line. A script clause is a way of executing >= 1 commands. |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
pushed a commit
that referenced
this pull request
Jul 12, 2023
Relevant changes for use of Pebble in Juju: * fix: exec and checks inherit environment from daemon (#234) * Allow non-root to specify user/group to itself (#239) * Add support for services to configure working directory (#245) * Improve error messages with exec, especially if working dir missing (#236) * Add "service context" support for exec and health checks (#246) Full list of changes here: canonical/pebble@5842ea6...00bcd1f
laszlokajtar
pushed a commit
to laszlokajtar/juju
that referenced
this pull request
Oct 25, 2023
Fix tutorial page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.