/juju

Don't automatically add env life assertions to txns #2801

Merged
merged 8 commits into from Jul 17, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mjs @wallyworld @jujubot
@mjs
Contributor

mjs commented Jul 16, 2015

The multiEnvRunner will no longer automatically add assertions on environment life to transactions as this create a serious performance bottleneck. Instead, the env is asserted to be alive in specific key areas (mainly where a txn may result in provisioning of resources).

Fixes LP #1474195

(Review request: http://reviews.vapour.ws/r/2180/)

mjs added some commits Jul 15, 2015

@mjs
state: moved assertEnvAliveOp... 
...to environ.go in preparation for env life assert fix.
4c8772f
@mjs
state: added env life assertions for machine creation 
Environment life is only asserted for top level machines, not
containers. Containers will get cleaned up anyway once the host
machine is killed.
5afeadc
@mjs
state: added checkEnvLife helper 
To be used to evaluate if a txn aborted because of the environment
life assertion.
bed4d4c
@mjs
state: added env life assertion for rebootC
c28d65f
@mjs
state: added env life assertions to networking related txns
48c2167
@mjs
state: cleaned up post txn env life check in AddService
c21df82
@mjs
state: added env life assertions for actions
05cc74c
@mjs
state: removed automatic addition of env life asserts 
This was creating a signficant performance bottleneck as almost all
txns were being serialised on the environment document.
3afa60d
@wallyworld
Owner

wallyworld commented Jul 16, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Jul 16, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Jul 16, 2015

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/4019
@wallyworld
Owner

wallyworld commented Jul 16, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Jul 16, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@mjs
Contributor

mjs commented Jul 16, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Jul 16, 2015

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/4022
@mjs
Contributor

mjs commented Jul 17, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Jul 17, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Jul 17, 2015

@jujubot
Merge pull request #2801 from mjs/1474195-env-assert-removal-1.24 
Don't automatically add env life assertions to txns

The multiEnvRunner will no longer automatically add assertions on environment life to transactions as this create a serious performance bottleneck. Instead, the env is asserted to be alive in specific key areas (mainly where a txn may result in provisioning of resources).

Fixes LP #1474195

(Review request: http://reviews.vapour.ws/r/2180/)
790cfab

@jujubot jujubot merged commit 790cfab into juju:1.24 Jul 17, 2015

@mjs mjs deleted the mjs:1474195-env-assert-removal-1.24 branch Jul 17, 2015

@mjs mjs referenced this pull request Jul 21, 2015

Merged

Don't automatically add env life assertions to txns #2851

jujubot added a commit that referenced this pull request Jul 23, 2015

@jujubot
Merge pull request #2851 from mjs/1474195-env-assert-removal 
Don't automatically add env life assertions to txns

This is a forward port of #2801, fixing LP #1474195.

The multiEnvRunner will no longer automatically add assertions on environment life to transactions as this create a serious performance bottleneck. Instead, the env is asserted to be alive in specific key areas (mainly where a txn may result in provisioning of resources).

(Review request: http://reviews.vapour.ws/r/2231/)
51477ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment