Don't automatically add env life assertions to txns #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 16, 2015 10:55
...to environ.go in preparation for env life assert fix.
To be used to evaluate if a txn aborted because of the environment life assertion.
Environment life is only asserted for top level machines, not containers. Containers will get cleaned up anyway once the host machine is killed.
This was creating a signficant performance bottleneck as almost all txns were being serialised on the environment document.
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
|
|
Build failed: Tests failed |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Jul 17, 2015
Don't automatically add env life assertions to txns The multiEnvRunner will no longer automatically add assertions on environment life to transactions as this create a serious performance bottleneck. Instead, the env is asserted to be alive in specific key areas (mainly where a txn may result in provisioning of resources). Fixes LP #1474195 (Review request: http://reviews.vapour.ws/r/2180/)
jujubot
added a commit
that referenced
this pull request
Jul 23, 2015
Don't automatically add env life assertions to txns This is a forward port of #2801, fixing LP #1474195. The multiEnvRunner will no longer automatically add assertions on environment life to transactions as this create a serious performance bottleneck. Instead, the env is asserted to be alive in specific key areas (mainly where a txn may result in provisioning of resources). (Review request: http://reviews.vapour.ws/r/2231/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multiEnvRunner will no longer automatically add assertions on environment life to transactions as this create a serious performance bottleneck. Instead, the env is asserted to be alive in specific key areas (mainly where a txn may result in provisioning of resources).
Fixes LP #1474195
(Review request: http://reviews.vapour.ws/r/2180/)