Env cmd manual #308
Merged
Env cmd manual #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -107,10 +107,11 @@ func (c *AddMachineCommand) Init(args []string) error { | |||
| } | |||
|
|
|||
| type AddMachineAPI interface { | |||
There was a problem hiding this comment.
public types need a comment
|
LGTM modulo comments. |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Jul 15, 2014
Env cmd manual This work removes the dependency that the manual provisioning had on the environment name. Instead, the provisioning requires something that supports the API it needs to call. This means that the interface that the add-machine command depends on needs a few more methods. The AddMachines client method is now used, and the 1.18 fall-back code is removed.
laszlokajtar
pushed a commit
to laszlokajtar/juju
that referenced
this pull request
Oct 25, 2023
…rule Update _patterns_p-subnav.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work removes the dependency that the manual provisioning had on the environment name.
Instead, the provisioning requires something that supports the API it needs to call. This means that the interface that the add-machine command depends on needs a few more methods.
The AddMachines client method is now used, and the 1.18 fall-back code is removed.