apiserver: do not access state in NewServer - fixes-1504578 #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogpeppe
force-pushed
the
060-apiserver-no-NewServer-state-access
branch
2 times, most recently
from
1b43885
to
20d26a6
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1504578'] |
|
|
rogpeppe
changed the title
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1504578'] |
|
fixes-1504578 |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
rogpeppe
force-pushed
the
060-apiserver-no-NewServer-state-access
branch
from
20d26a6
to
2def502
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Oct 14, 2015
…te-access apiserver: do not access state in NewServer - fixes-1504578 We also ensure that the listener is closed when NewServer fails and that we allow an agent login without requiring the environment configuration (that's also potentially problematic if the user database needs a migration but not something we can easily sort out now). We also remove apiclientSuite.TestConnectWebsocketPrefersLocalhostIfPresent because the logic it was supposed be testing has long been removed and didn't actually test that logic in the first place. Fixes https://bugs.launchpad.net/juju-core/+bug/1504578. fixes-1504578 ['fixes-1504578'] (Review request: http://reviews.vapour.ws/r/2878/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also ensure that the listener is closed when NewServer fails and that we allow an agent login without requiring the environment configuration (that's also potentially problematic if the user database needs a migration but not something we can easily sort out now).
We also remove apiclientSuite.TestConnectWebsocketPrefersLocalhostIfPresent because the logic it was supposed be testing has long been removed and didn't actually test that logic in the first place.
Fixes https://bugs.launchpad.net/juju-core/+bug/1504578.
fixes-1504578
['fixes-1504578']
(Review request: http://reviews.vapour.ws/r/2878/)