Fixed lp:1520199: Better handling of MAAS errors around address allocation #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 1, 2015 11:42
…d the devices warning
… IPs for containers
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Dec 2, 2015
Fixed lp:1520199: Better handling of MAAS errors around address allocation A few issues fixed in provider/maas: * Errors and unexpected responses from MAAS devices API are now logged and returned when relevant, rather than ignored in a few cases. * Better support for MAAS nodes with NICs having both IPv4 and IPv6 addresses (for the same MAC address) from subnets with allocatable static ranges. * Correct handling of multiple IPv6 gateways in the MAAS bridge script. * Related to bug http://pad.lv/1519527 - claim_sticky_ip_address response is verified to contain an IP address for the container. If it doesn't have it, report and error (rather than cause all containers to get the same IP as described in the bug above). See bug http://pad.lv/1520199 for more details. Live tested on MAAS 1.7, 1.8, and 1.9rc2 with and without the addressable containers feature flag, using LXC containers, both on trusty and precise. (Review request: http://reviews.vapour.ws/r/3285/)
This was referenced Dec 2, 2015
jujubot
added a commit
that referenced
this pull request
Dec 2, 2015
Forward port PR #3866 from 1.25 to master Same as #3866, tested the same way. (Review request: http://reviews.vapour.ws/r/3295/)
jujubot
added a commit
that referenced
this pull request
Dec 2, 2015
maas: Fix a go vet warning Fixes an issue discovered in #3866 by running ./scripts.verify.bash: ``` $ ./scripts/verify.bash go version go1.2.1 checking: go fmt ... checking: go vet ... provider/maas/environ.go:121: missing argument for Debugf verb %q: need 2, have 1 checking: go build ... checking: tests are wired up ... ``` (Review request: http://reviews.vapour.ws/r/3296/)
jujubot
added a commit
that referenced
this pull request
Jan 12, 2016
Revert PRs #3730 #3866 #3877 #3966 (which switched to using devices for containers) Using devices by default for containers as a behavior is being backed out as it turns out MAAS 1.8 (latest stable in trusty) doesn't do a full cleanup of the devices IPs, so in fact using devices makes things worse. It was decided to back out the original #3730 and the follow-ups to it like #3966 and #3866 (they fix issues introduced by the first PR, e.g. http://pad.lv/1520199 and http://pad.lv/1525280). Tested on 1.7, 1.8, and 1.9 to confirm devices are not created unless the address-allocation feature flag is on (and then on 1.8+ only, as 1.7 doesn't support devices). (Review request: http://reviews.vapour.ws/r/3474/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few issues fixed in provider/maas:
and returned when relevant, rather than ignored in a few cases.
addresses (for the same MAC address) from subnets with allocatable
static ranges.
response is verified to contain an IP address for the container. If
it doesn't have it, report and error (rather than cause all
containers to get the same IP as described in the bug above).
See bug http://pad.lv/1520199 for more details.
Live tested on MAAS 1.7, 1.8, and 1.9rc2 with and without the
addressable containers feature flag, using LXC containers, both on
trusty and precise.
(Review request: http://reviews.vapour.ws/r/3285/)