New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maas: Make spaces constraints work on MAAS 1.9+ #3921
maas: Make spaces constraints work on MAAS 1.9+ #3921
Conversation
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
…he new spaces API
648bfab
to
f951dd8
Compare
Build failed: boo |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Build failed: Generating tarball failed |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
maas: Make spaces constraints work on MAAS 1.9+ This PR introduces 2 main changes: * Subnets() can now be called without instance ID and/or empty subnet IDs when we detect the new MAAS 1.9 API is available * acquireNode API properly transforms spaces constraints and interface bindings into "interfaces=" argument. Bindings override spaces constraints when both exist, however there's no way yet to pass explicit interface bindings. Added more tests around the various ways Subnets() is being called and implemented - with older and newer MAAS APIs. Live tested on MAAS 1.9RC3 to ensure the following steps work: ``` $ juju bootstrap --upload-tools $ juju space create space-0 # matching existing one in MAAS $ juju subnet add 10.20.19.0/24 default # zone is required (e.g. "default") $ juju deploy mysql --constraints spaces=space-0 ``` Also, for a more real-life-like demo, I managed to deploy a modified mediawiki bundle (http://paste.ubuntu.com/13837091/) once the subnets, VLANs, and spaces were preconfigured like this: http://paste.ubuntu.com/13837104/ and I've run: ``` $ juju space create admin $ juju space create public $ juju subnet add 10.50.19.0/24 admin default $ juju subnet add 10.100.19.0/24 public default ``` Discovered an issue with the bridge script - it's not handling VLANs correctly, so I needed to use `disable-network-management: true` as a workaround (otherwise bootstrap failed). (Review request: http://reviews.vapour.ws/r/3342/)
If i try to use spaces in juju 1.25.5 with MAAS 1.9.2 is get this error:
Must i activate the space usage first? |
On 05/10/2016 04:47 PM, Kim-Norman Sahm wrote:
Juju 1.25 does not yet support spaces on MAAS, Juju 2.0 does, but the Also, spaces are only discovered by Juju (automatically at bootstrap), Cheers,Dimiter Naydenov dimiter.naydenov@canonical.com |
This PR introduces 2 main changes:
IDs when we detect the new MAAS 1.9 API is available
bindings into "interfaces=" argument. Bindings override spaces
constraints when both exist, however there's no way yet to pass
explicit interface bindings.
Added more tests around the various ways Subnets() is being called and
implemented - with older and newer MAAS APIs.
Live tested on MAAS 1.9RC3 to ensure the following steps work:
Also, for a more real-life-like demo, I managed to deploy a modified
mediawiki bundle (http://paste.ubuntu.com/13837091/) once the subnets,
VLANs, and spaces were preconfigured like this: http://paste.ubuntu.com/13837104/
and I've run:
Discovered an issue with the bridge script - it's not handling VLANs
correctly, so I needed to use
disable-network-management: true
as aworkaround (otherwise bootstrap failed).
(Review request: http://reviews.vapour.ws/r/3342/)