Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature resources #4408

Merged
merged 538 commits into from Feb 12, 2016
Merged

Feature resources #4408

merged 538 commits into from Feb 12, 2016

Conversation

sinzui
Copy link
Contributor

@sinzui sinzui commented Feb 12, 2016

This feature branch merge into master. There are two failures seen by CI
http://reports.vapour.ws/releases/3603
and we can see these regressions came from master.

There are no outstanding bugs...there were never any bugs reported against it.

(Review request: http://reviews.vapour.ws/r/3849/)

natefinch and others added 26 commits February 10, 2016 00:38
rename show-service-resources to list-resources

and remove the show-charm-resources command since it's being written in a different commit and conflicts with the alias for list-resources

(Review request: http://reviews.vapour.ws/r/3777/)
change description to comment and remove comment from tabular output

note that this updates the dependencies, so you'll need to rerun godeps when this lands

(Review request: http://reviews.vapour.ws/r/3813/)
Conflicts:
    api/service/client.go
    api/service/client_test.go
    apiserver/params/params.go
    apiserver/service/service.go
    cmd/juju/service/deploy.go
    dependencies.tsv
    juju/deploy.go
    juju/deploy_test.go
    state/state.go
…harm-resources command since it's being written in a different commit and conflicts with the alias for list-resources
Rename "juju resources" to "juju charm list-resources".

A key part of this is adding the "juju charm" command.

(Review request: http://reviews.vapour.ws/r/3778/)
… juju resources <unit> --details, since it was useless printing out the unit number.
Implement juju resources --details flag

This adds a --details flag that does a diff of the expected resources on each unit, and the actual resources.

(Review request: http://reviews.vapour.ws/r/3818/)
@sinzui
Copy link
Contributor Author

sinzui commented Feb 12, 2016

$$merge$$ JFDI

@jujubot
Copy link
Collaborator

jujubot commented Feb 12, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Feb 12, 2016
Feature resources

This feature branch merge into master. There are two failures seen by CI
    http://reports.vapour.ws/releases/3603
and we can see these regressions came from master.

There are no outstanding bugs...there were never any bugs reported against it.

(Review request: http://reviews.vapour.ws/r/3849/)
@jujubot jujubot merged commit 3f98d44 into master Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants