Switch off direct database access #449
Conversation
|
I've tested Amazon and openstack (canonistack) bootstrapping and a basic deploy to check they still function (all good). I've also confirmed that with current master I can telnet to port 37017, and that with this branch I can't. |
|
What happens to 1.18.1 clients ? Do we need to continue to support them for On Fri, Aug 1, 2014 at 8:06 AM, Michael Foord notifications@github.com
|
|
An answer from William on this topic. I'm pretty sure that 1.18 had switched to the API everywhere -- but it still needed direct-mongo-access code to interact with 1.16 installations. If we hadn't switched by then we screwed up royally by releasing it -- waiting for API everywhere was one of the big reasons we waited so long to release it. I'm trying a 1.18 client with this branch now to check that basic functions work. |
|
So, the 1.18 client doesn't like the "alpha" in our trunk version number. "juju status" works fine, but a deploy complains about the invalid agent version. As a smoke test "juju status" working fine is a good sign though... |
|
Excellent news, my fears were unfounded. On Fri, Aug 1, 2014 at 7:00 PM, Michael Foord notifications@github.com
|
|
This LGTM as far as it goes, but I'd also like to see a followup with upgrade steps (I guess?) that tell the environs to actually close any mongo port that was left open by the previous versions. |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1350983', 'fixes-1350911', 'fixes-1347715', 'fixes-1351030', 'fixes-1351019'] |
|
Fixes-1253652. |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1350983', 'fixes-1350911', 'fixes-1347715', 'fixes-1351030', 'fixes-1351019'] |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Switch off direct database access No longer expose port 37017 on machines as direct mongo access is no longer required.
Shut-off direct database access No longer expose port 37017 on machines, as direct mongo access is no longer required. This is a repeat of PR 449 (effectively a revert of the revert). #449 This was reverted because restore still used direct state access. Once PR 561 has been merged direct DB access can be shutoff (again). #561
No longer expose port 37017 on machines as direct mongo access is no longer required.