/juju

Juju uses mongo 3.2 on xenial; fix upgrade mongo tests #4715

Merged
merged 1 commit into from Apr 5, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wallyworld @cherylj @jujubot
@wallyworld
Owner

wallyworld commented Mar 14, 2016

On xenial juju will attempt to install mongo 3.2 and use that. Previously 3.0 was used. Wired tiger is used on all architectures by default so some tests needed changing to match.
Part of the implementation cleaned up a bit how the mongo paths are managed.

This work will land once mongo3.2 is packaged for xenial.

Once mongo3.2 is backported to trusty, juju will need to be updated again to use mongo3.2 on trusty.

It was discovered that the upgrade mongo tests were, um, "not optimally implemented". They used a hard coded retry strategy that caused some tests to take 60s to run. The tests are re-written to use the retry package and sensible test defaults. The tests are now fast.

(Review request: http://reviews.vapour.ws/r/4153/)
@cherylj

cherylj commented Apr 5, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Apr 5, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Apr 5, 2016

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7188

cherylj pushed a commit to cherylj/juju that referenced this pull request Apr 5, 2016

Fix go fmt errors. 
mongo/mongo.go was missing some whitespace and it
made go fmt sad (which prevented me from merging
wallyworld's PR:  juju#4715
ad2151b

@cherylj cherylj referenced this pull request Apr 5, 2016

Merged

Merge mongo 3.2 PR from wallyworld #4997

@cherylj

cherylj commented Apr 5, 2016

Had to fix some go fmt issues, so using PR: #4997 for merging this change.

@jujubot jujubot merged commit c741769 into juju:master Apr 5, 2016

jujubot added a commit that referenced this pull request Apr 5, 2016

@jujubot
Merge pull request #4997 from cherylj/fix-go-fmt 
Merge mongo 3.2 PR from wallyworld

This PR merges wallyworld's already reviewed PR: #4715

But now with extra go fmt happiness (whitespace change, self-reviewed)

(Review request: http://reviews.vapour.ws/r/4436/)
d9b6bc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment