Juju uses mongo 3.2 on xenial; fix upgrade mongo tests #4715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
cherylj
pushed a commit
to cherylj/juju
that referenced
this pull request
Apr 5, 2016
mongo/mongo.go was missing some whitespace and it made go fmt sad (which prevented me from merging wallyworld's PR: juju#4715
|
Had to fix some go fmt issues, so using PR: #4997 for merging this change. |
jujubot
added a commit
that referenced
this pull request
Apr 5, 2016
Merge mongo 3.2 PR from wallyworld This PR merges wallyworld's already reviewed PR: #4715 But now with extra go fmt happiness (whitespace change, self-reviewed) (Review request: http://reviews.vapour.ws/r/4436/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On xenial juju will attempt to install mongo 3.2 and use that. Previously 3.0 was used. Wired tiger is used on all architectures by default so some tests needed changing to match.
Part of the implementation cleaned up a bit how the mongo paths are managed.
This work will land once mongo3.2 is packaged for xenial.
Once mongo3.2 is backported to trusty, juju will need to be updated again to use mongo3.2 on trusty.
It was discovered that the upgrade mongo tests were, um, "not optimally implemented". They used a hard coded retry strategy that caused some tests to take 60s to run. The tests are re-written to use the retry package and sensible test defaults. The tests are now fast.
(Review request: http://reviews.vapour.ws/r/4153/)