New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gce provider: fix daily image URL #4902
Conversation
Signed-off-by: Tycho Andersen <tycho.andersen@canonical.com>
For some context,
|
@@ -202,7 +202,7 @@ var getDisksTests = []struct { | |||
|
|||
func (s *environBrokerSuite) TestGetDisks(c *gc.C) { | |||
for _, test := range getDisksTests { | |||
diskSpecs, err := gce.GetDisks(s.spec, s.StartInstArgs.Constraints, test.Series, "32f7d570-5bac-4b72-b169-250c24a94b2b") | |||
diskSpecs, err := gce.GetDisks(s.spec, s.StartInstArgs.Constraints, test.Series, "32f7d570-5bac-4b72-b169-250c24a94b2b", false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty clear that we need to add another test, or maybe another scenario permutation about how we handle Daily images.
Possibly another test higher up that we notice that "daily" images actually get them from another source? But definitely one at this level that the URL changes if you ask for dailies.
The change looks fine, but we need some tests so that other people coming to this can understand what it should be doing. |
Signed-off-by: Tycho Andersen <tycho.andersen@canonical.com>
Thanks, I added the test. |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Build failed: Generating tarball failed |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Signed-off-by: Tycho Andersen tycho.andersen@canonical.com