Fix LP-1355521 :: update config before making the worker #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Wonder if this was a merge/rebase issue... |
|
JFDI |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1347715', 'fixes-1355324'] |
|
JFDI |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Aug 12, 2014
Fix LP-1355521 :: update config before making the worker Fixes lp-1355521 s.updateConfig was happening *after* the suite already set up the worker. This resulted in the environment not being consistently initialized, and resulted in the test timing out after 10 minutes on my machine. Moving the s.updateConfig call to the beginning of the test, like all the other tests in this file, resolved the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes lp-1355521
s.updateConfig was happening after the suite already set up the worker. This resulted in the environment not being consistently initialized, and resulted in the test timing out after 10 minutes on my machine.
Moving the s.updateConfig call to the beginning of the test, like all the other tests in this file, resolved the issue.