Backport cb9cf61b from master to fix feature flag tear down test break on windows #5062
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LP 1566303 (for real this time)
Backport cb9cf61 from master to fix feature flag tear down test break on windows.
The underlying cause is the feature tests run in parallel, and all try to mutate one registry key. The logic is roughly
This pattern is unsafe, we have to rewrite it to not use a singleton registry key. And apparently Tim did this on master, so backport that fix.
(Review request: http://reviews.vapour.ws/r/4505/)