Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport cb9cf61b from master to fix feature flag tear down test break on windows #5062

Merged
merged 1 commit into from Apr 11, 2016
Merged

Backport cb9cf61b from master to fix feature flag tear down test break on windows #5062

merged 1 commit into from Apr 11, 2016

Conversation

davecheney
Copy link
Contributor

Fixes LP 1566303 (for real this time)

Backport cb9cf61 from master to fix feature flag tear down test break on windows.

The underlying cause is the feature tests run in parallel, and all try to mutate one registry key. The logic is roughly

  • program A creates registry key (as it doesn't exist), and records the fact that it must delete the registry key.
  • program B trys to create a registry key, finds that it already exists, so it records the old value, then updates it, and makes a not to restore the old value.
  • program A deletes the registry key, as when it started the key did not exist, so it's behaviour is to remove the key.
  • Program b trys to restore the state of the existing key, and finds the key deleted.
  • Test fails.

This pattern is unsafe, we have to rewrite it to not use a singleton registry key. And apparently Tim did this on master, so backport that fix.

(Review request: http://reviews.vapour.ws/r/4505/)

@davecheney
Copy link
Contributor Author

$$JFDI$$

@jujubot
Copy link
Collaborator

jujubot commented Apr 10, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Apr 11, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7281

@davecheney
Copy link
Contributor Author

$$JFDI$$

@jujubot
Copy link
Collaborator

jujubot commented Apr 11, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Apr 11, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7301

@bz2
Copy link
Contributor

bz2 commented Apr 11, 2016

$$fixes-1566303$$

@jujubot
Copy link
Collaborator

jujubot commented Apr 11, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit d6877b5 into juju:1.25 Apr 11, 2016
@davecheney davecheney deleted the backport/xxx branch April 11, 2016 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants