apiserver: Per model directory for charm get cache #5081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 12, 2016 11:08
Fixes LP #1541482. Local charms in different models of the same controller were sharing the same cache filename when they had the same charm URL. This was causing charm hash mismatches when units downloaded a charm and received a different version to what was expected.
Fixed some unnecessarily strange defers and documents some non-obvious details.
|
Retargetting to "next" branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LP #1541482.
Local charms in different models of the same controller were sharing the same cache filename when they had the same charm URL. This was causing charm hash mismatches when units downloaded a charm and received a different version to what was expected.
Also simplified temp file cleanup during charm download.
(Review request: http://reviews.vapour.ws/r/4524/)