worker/peergrouper: Fix data race in tests #5225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestHasVoteMaintainedEvenWhenReplicaSetFails was neglecting to stop one of the workers it started. The leaked worker would read of variables which were being patched by later tests in the suite. The race detector would occasionally pick this up, depending on timing. Drive-by: standardised on the workertest.CleanKill helper for shutting down the workers throughout the suite.
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestHasVoteMaintainedEvenWhenReplicaSetFails was neglecting to stop one of the workers it started. The leaked worker would read of variables which were being patched by later tests in the suite. The
race detector would occasionally pick this up, depending on timing.
Drive-by: standardised on the workertest.CleanKill helper for shutting down the workers throughout the suite.
Fixes LP #1467715.
(Review request: http://reviews.vapour.ws/r/4650/)