/juju

Update gomaasapi to fix nil reference panic #5271

Merged
merged 2 commits into from Apr 25, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@babbageclunk @jujubot
@babbageclunk
Member

babbageclunk commented Apr 25, 2016

This fixes the panic in https://bugs.launchpad.net/juju-core/+bug/1573659 - interface nil values were being returned as typed nils and so the nil check for link.Subnet() in maas2NetworkInterfaces wasn't working as intended.

Confirmed that with this change I can now bootstrap to a machine with an unconfigured NIC such that link.Subnet() is nil.

(Review request: http://reviews.vapour.ws/r/4696/)
@babbageclunk
Update gomaasapi - fixes nil reference panic 
This fixes the panic in http://pad.lv/1573659 - interface nil values were
being returned as typed nils and so the nil check for link.Subnet() in
maas2NetworkInterfaces wasn't working as intended.
073fea8
@babbageclunk
Member

babbageclunk commented Apr 25, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Apr 25, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Apr 25, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7540
@babbageclunk
Change fakeBlockDevice.Size() to uint64 
Needed to change to match the updated interface in gomaasapi.
884f2a8
@babbageclunk
Member

babbageclunk commented Apr 25, 2016

Oops, the type of BlockDevice.Size() changed to unit64, updated tests and reran.
$$retry$$
@jujubot
Contributor

jujubot commented Apr 25, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit b4921bf into juju:master Apr 25, 2016

@babbageclunk babbageclunk deleted the babbageclunk:nil-subnet branch Apr 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment