Update gomaasapi to fix nil reference panic #5271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the panic in http://pad.lv/1573659 - interface nil values were being returned as typed nils and so the nil check for link.Subnet() in maas2NetworkInterfaces wasn't working as intended.
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
Needed to change to match the updated interface in gomaasapi.
|
Oops, the type of BlockDevice.Size() changed to unit64, updated tests and reran. |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the panic in https://bugs.launchpad.net/juju-core/+bug/1573659 - interface nil values were being returned as typed nils and so the nil check for link.Subnet() in maas2NetworkInterfaces wasn't working as intended.
Confirmed that with this change I can now bootstrap to a machine with an unconfigured NIC such that link.Subnet() is nil.
(Review request: http://reviews.vapour.ws/r/4696/)