dependencies.tsv: update golang.org/x/crypto dep #5289

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

davecheney commented Apr 27, 2016

Fixes LP #1458585

With the 2015/03/27 dependency my stress test would fail after a few
runs, with this up to date dependency the stress test does not fail.

This PR requires Go 1.5 or later.

(Review request: http://reviews.vapour.ws/r/4716/)

dependencies.tsv: update golang.org/x/crypto dep
Fixes LP #1458585

With the 2015/03/27 dependency my stress test would fail after a few
runs, with this up to date dependency the stress test does not fail.

This PR requires Go 1.5 or later.
Contributor

davecheney commented Apr 27, 2016

$$merge$$

Let's see if this works

Contributor

jujubot commented Apr 27, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Apr 27, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7578

Contributor

davecheney commented Apr 28, 2016

$$merge$$

Contributor

jujubot commented Apr 28, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Apr 28, 2016

Build failed: Does not match ['fixes-1576021']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7594

Contributor

davecheney commented Apr 28, 2016

$$JFDI$$

Contributor

jujubot commented Apr 28, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Apr 28, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7595

Contributor

davecheney commented Apr 28, 2016

Nope, still running go 1.2.1.

go version go1.2.1 linux/amd64

  • make build
    skipping godeps
    go build github.com/juju/juju/...

    golang.org/x/crypto/ssh

    ../../../golang.org/x/crypto/ssh/keys.go:572: undefined: crypto.Signer

On Fri, Apr 29, 2016 at 7:21 AM, Juju bot notifications@github.com wrote:

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7595


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#5289 (comment)

Contributor

davecheney commented May 16, 2016

$$merge$$

Contributor

jujubot commented May 16, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented May 16, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7739

Owner

howbazaar commented Aug 8, 2016

$$merge$$

Contributor

jujubot commented Aug 8, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Aug 8, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/8661

Member

anastasiamac commented Nov 1, 2016

This is no longer Critical for 1.25.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment