state/apiserver/common: drop EnvironWatcher.canWatch #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all cases canWatch was being populated with the common.AuthAlways factory; in effect canWatch(anything) would always return true. The only case where it did not return true was in our unit test cases which would force the value to be false to generate a suprious ErrPerm which was then validated by the tests.
|
Seems reasonable to me. I can't foresee a position where we wouldn't be able to watch the environment at all. It seems so central to all worker interaction. |
|
LGTM |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Aug 18, 2014
…vironwatcher-drop-canwatch state/apiserver/common: drop EnvironWatcher.canWatch In all cases canWatch was being populated with the common.AuthAlways factory; in effect canWatch(anything) would always return true. The only case where it did not return true was in our unit test cases which would force the value to be false to generate a suprious ErrPerm which was then validated by the tests.
davecheney
deleted the
177-state-apiserver-common-environwatcher-drop-canwatch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all cases canWatch was being populated with the common.AuthAlways factory; in effect canWatch(anything) would always return true.
The only case where it did not return true was in our unit test cases which would force the value to be false to generate a suprious ErrPerm which was then validated by the tests.